use simpler callable check for meta_eval#323
Merged
SylvainCorlay merged 1 commit intoipython:masterfrom Sep 23, 2016
Merged
Conversation
instead of `is function`
Contributor
|
@minrk now that you are at it, you can change the following docstring to explain that plain-values as filters are also supported? def traits(self, **metadata):
"""Get a ``dict`` of all the traits of this class. The dictionary
is keyed on the name and the values are the TraitType objects.
The TraitTypes returned don't know anything about the values
that the various HasTrait's instances are holding.
The metadata kwargs allow to filter traits based on metadata values.
Each keyword might be a callable or a plain value.
- If it is a callable, the signature must be::
filter(metadata_value) -> bool
Return False to skip the trait from the output. If a metadata key
doesn't exist, None will be passed to the function.
- Otherwise, the metadata named as the key is checked for equality
against its value, and included in the output if they match.
Example:
## Fetch only traits with `config == True` metadata.
has_traits.traits(config=True)
""" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of
type() is FunctionType